-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Add support for delegated bypass in code security org config #3920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for delegated bypass in code security org config #3920
Conversation
|
Tested with our company enterprise where we try to configure code security programmatically. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3920 +/- ##
=======================================
Coverage 92.45% 92.45%
=======================================
Files 203 203
Lines 14954 14954
=======================================
Hits 13826 13826
Misses 926 926
Partials 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @tstollin.
Please unit tests (either new or update existing ones) that demonstrate the inclusion of the new fields.
bfe41ab to
7c9b5c7
Compare
… of an organization
7c9b5c7 to
01125e4
Compare
Thanks for the feedback @gmlewis. I've added a new unit test and the |
|
Unfortunately, I missed point 6. of "submitting a patch" in your https://github.com/google/go-github/blob/master/CONTRIBUTING.md and did force-pushes. :( |
It's OK... this is a relatively small PR, so no problem. |
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @tstollin!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29
|
Whups! I spoke too soon. Please run step 4 again and push the changes, and this should be good to go, @tstollin. Thank you. |
oh, i ran the scripts but I missed the |
|
Thank you, @tstollin and @alexandear! |
Fixes: #3918.